• core in term

    From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tue Sep 19 11:33:25 2023
    https://gitlab.synchro.net/main/sbbs/-/issues/630#note_4195

    In this case, we're not seeing any NULL'd cfg->event[] items. I still suspect something was in the process of freeing the cfg struct. The only thing that should do that (for a terminal node's config copy) is cleanup() in main.cpp which is only called upon shutdown or recycle, and even then, it first waits (up to 60 seconds) for all node threads to terminate. The message "Waiting for X node threads to terminate..." is logged (info-level) before this wait (and "Done waiting for node threads to terminate" is logged after the wai). Can you check and see if you have any such log messages around the time of these crashes?Lastly, just before the node's config structs are freed, the info-level message "Terminal Server thread terminating" is logged. Please check and see if that message is logged around the time of the crashes. Thanks.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Nigel Reed@1:103/705 to GitLab note in main/sbbs on Tue Sep 19 14:31:54 2023
    https://gitlab.synchro.net/main/sbbs/-/issues/630#note_4196

    -rw------- 1 bbs bbs 1521917952 Sep 17 07:35 '/tmp/core.sbbs!termNode.1907853'~~~Sep 17 07:35:21 bbs synchronet: term Node 1 JavaScript: Creating node runtime: 134217728 bytesSep 17 07:35:21 bbs synchronet: term Node 1 07:35 Sun Sep 17 2023 Node 1Sep 17 07:35:21 bbs synchronet: term Node 1 Telnet <no name> [221.168.89.195]Sep 17 07:35:21 bbs synchronet: term Node 2 no Telnet commands received, reverting to Raw TCP modeSep 17 07:35:21 bbs synchronet: term Node 2 terminal type: 80x24 DUMBSep 17 07:35:56 bbs synchronet: term Synchronet Terminal Server Version 3.20a DebugSep 17 07:35:56 bbs synchronet: term Compiled master/f28c4bc94 Sep 17 2023 01:37:18 with GCC 11.4.0Sep 17 07:35:56 bbs synchronet: term sizeof: int=4, long=8, off_t=8, time_t=8Sep 17 07:35:56 bbs synchronet: term Initializing on Sun Sep 17 07:35:56 2023 with options: 1022Sep 17 07:35:56 bbs synchronet: term Loading configuration files from /sbbs/ctrl/Sep 17 07:35:56 bbs synchronet: term MQTT lib: mosquitto 2.0.11Sep 17 07:35:56 bbs synchronet: term MQTT connecting to broker 127.0.0.1:1883Sep 17 07:35:56 bbs synchronet: term MQTT broker-connect (127.0.0.1:1883) successfulSep 17 07:35:56 bbs synchronet: term Verifying/creating data directoriesSep 17 07:35:56 bbs synchronet: term Verifying/creating node directoriesSep 17 07:35:56 bbs synchronet: term Telnet Server listening on socket 0.0.0.0 port 23~~~There are not "Done waiting for node threads" since Sep 15.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Nigel Reed@1:103/705 to GitLab note in main/sbbs on Tue Sep 19 18:29:59 2023
    https://gitlab.synchro.net/main/sbbs/-/issues/630#note_4200

    Here's node 3 activity~~~Sep 17 02:11:58 bbs synchronet: term Node 3 <Crashtestdummy> Scrolled 8 mouse hot-spots 1 rows (8 remain)Sep 17 02:11:58 bbs synchronet: term Node 3 <Crashtestdummy> Scrolled 8 mouse hot-spots 1 rows (8 remain)Sep 17 02:14:15 bbs synchronet: term Node 3 <Crashtestdummy> Scrolled 8 mouse hot-spots 1 rows (8 remain)Sep 17 02:14:15 bbs synchronet: term Node 3 <Crashtestdummy> Invoked string command: EVAL user.editorSep 17 02:14:15 bbs synchronet: term Node 3 <Crashtestdummy> Scrolled 8 mouse hot-spots 1 rows (8 remain)Sep 17 02:14:15 bbs synchronet: term Node 3 <Crashtestdummy> Scrolled 8 mouse hot-spots 1 rows (8 remain)ep 17 07:34:46 bbs synchronet: term Node 3 Loading configuration files from /sbbs/ctrl/Sep 17 07:34:46 bbs synchronet: term Node 3 constructor using socket 121 (settings=8212)Sep 17 07:34:46 bbs synchronet: term Node 3 temporary file directory: /sbbs/node3/temp/~~~and then just around the time of the crash:~~~Sep 17 07:35:21 bbs synchronet: term Node 2 no Telnet commands received, reverting to Raw TCP modeSep 17 07:35:21 bbs synchronet: term Node 2 terminal type: 80x24 DUMBSep 17 07:35:56 bbs synchronet: term Synchronet Terminal Server Version 3.20a DebugSep 17 07:35:56 bbs synchronet: term Compiled master/f28c4bc94 Sep 17 2023 01:37:18 with GCC 11.4.0~~~
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Nigel Reed@1:103/705 to GitLab note in main/sbbs on Sat Dec 16 11:24:53 2023
    https://gitlab.synchro.net/main/sbbs/-/issues/630#note_4563

    I have not seen any more issues this this commit so feel free to close this one out if you're happy that it's fixed.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab issue in main/sbbs on Sat Dec 16 12:55:56 2023
    close https://gitlab.synchro.net/main/sbbs/-/issues/630
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)